[Master]-Bug 641503 Financial Reporting - Duplicate Rows in Financial Report Excel Export After Adding GL Budget Dimension#9129
Draft
v-praghav wants to merge 3 commits into
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Account Schedule Excel export (Report 29) to better control blank rows/cells around the filter header area, and adds/extends test coverage to validate dimension filter content and ensure “Currency” is not duplicated in the exported sheet.
Changes:
- Updated Report 29 (W1/NA) to insert/clear specific blank rows/cells via a new helper procedure to stabilize the export layout.
- Added a new ERM test (W1/NA/CZ) covering export with 4 dimension filters and asserting “Currency” appears exactly once in the Excel output.
- Added supporting test helper/assertion logic and a new label for clearer failure messaging.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Layers/W1/BaseApp/Finance/FinancialReports/ExportAccSchedtoExcel.Report.al | Replaces direct RowNo increments with a helper to insert/clear blank rows/cells during Excel export. |
| src/Layers/NA/BaseApp/Finance/FinancialReports/ExportAccSchedtoExcel.Report.al | Same export layout changes as W1 layer to keep behavior consistent. |
| src/Layers/W1/Tests/ERM/ERMAccountScheduleII.Codeunit.al | Adds a new export test and helper to validate dimension filters and detect duplicated “Currency” text. |
| src/Layers/NA/Tests/ERM/ERMAccountScheduleII.Codeunit.al | Mirrors the new W1 export test and helper in the NA test layer. |
| src/Layers/CZ/Tests/ERM/ERMAccountScheduleII.Codeunit.al | Mirrors the new W1 export test and helper in the CZ test layer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
v-praghav
changed the title
v-ankitgoyal
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#641503
What & why
Linked work
AB#641503
Fixes #
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility